Notice: This Wiki is now read only and edits are no longer possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Difference between revisions of "PTP/Gerrit"
< PTP
(→PTP Gerrit) |
(→PTP Gerrit) |
||
| Line 13: | Line 13: | ||
# The change is presumably documented in a bugzilla bug, e.g. https://bugs.eclipse.org/bugs/show_bug.cgi?id=407003 | # The change is presumably documented in a bugzilla bug, e.g. https://bugs.eclipse.org/bugs/show_bug.cgi?id=407003 | ||
| − | # Go to the URL for the change (e.g. bug 407003 has a link to https://git.eclipse.org/r/#/q/status:open+project:ptp/org.eclipse.ptp,n,z which has 10 Gerrit patch sets(?) for this bug) | + | # Go to the URL for the change (e.g. bug 407003 has a link to https://git.eclipse.org/r/#/q/status:open+project:ptp/org.eclipse.ptp,n,z which has 10 Gerrit patch sets(?) for this bug) - a patch set is a single commit? |
# Open the Patch Set (e.g. open the top on for this bug) | # Open the Patch Set (e.g. open the top on for this bug) | ||
# Click on each file, review the changes, add comments in line if required | # Click on each file, review the changes, add comments in line if required | ||
Revision as of 20:08, 18 November 2013
PTP Gerrit
UNDER DEVELOPMENT
PART 1 - What PTP contributors (committers and others) need to do for the basic tasks
- Contributor add a proposed fix/patch to Gerrit
- Clone the repo
- Configure the repo to use Gerrit (modify or create a remote that uses port 29418 or git.eclipse.org/r
- Make changes
- Commit the changes (to local repo) making sure that the commit includes Signed-off-by and Change-Id lines#. Team>Remote>Push to Gerrit...
PART 2 - What a committer needs to do to pull a gerrit patch in, see its changes, and later commit it to the repo to get in the build.
- The change is presumably documented in a bugzilla bug, e.g. https://bugs.eclipse.org/bugs/show_bug.cgi?id=407003
- Go to the URL for the change (e.g. bug 407003 has a link to https://git.eclipse.org/r/#/q/status:open+project:ptp/org.eclipse.ptp,n,z which has 10 Gerrit patch sets(?) for this bug) - a patch set is a single commit?
- Open the Patch Set (e.g. open the top on for this bug)
- Click on each file, review the changes, add comments in line if required
- The "Download" field on the main screen shows different ways of obtaining the changes in order to test in your local repo (from command line only?)
- On the main screen, click on the "Add Comment" button and add an overall comment on the change
- Using "Publish Comments" to add the comment
- If the change is rejected, the contributor can upload a new patch set, then the process is repeated
- If the change is accepted, sign off on the change by voting +2
- Once there is a +2 vote, use Publish and Submit to push the changes to the main repo
We also plan to add an auto build step so that hudson will automatically try to build with the change (and run tests too). If the build succeeds, hudson will vote on the change. The Gerrit-based build is separate from the build based on code committed to the repository.